fix: only disable HasLegacyNode call for verkle-at-genesis testnets #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
added a commit
that referenced
this pull request
May 7, 2024
gballet
added a commit
that referenced
this pull request
May 8, 2024
gballet
added a commit
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#283 introduced a workaround in order not to call
HasLegacyNode, which had no meaning in the verkle world and was causing a root comparison to fail.Because the branch was meant to be temporary, this workaround made sense. But now that it has become somewhat official, it makes sense to make this workaround a bit more stable, since it creates a deadlock in tests.
This PR only activates the workaround in the case of a verkle-at-genesis testnet.