Bump file-loader dependency to latest (6.1.0) #27224
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm having issues with a yarn workspaces environment that hosts both a gatsby-based site, and a https://github.com/facebook/docusaurus site. Gatsby and Docusaurus install different versions of a dependency,
file-loader
. Gatsby installs 1.1.11 from 3 years ago, and Docusaurus installs 6.0.0.For some yarn-workspaces related reason that I don't fully understand, Docusaurus then winds up importing the older dependency that Gatsby specifies (facebook/docusaurus#3515) rather than the one that it specifies. This results in my Docusaurus site not being able to build, but if I remove the Gatsby project, the Docusaurus site builds fine.
I was curious if we could please bump the Gatsby dependency on file-loader? This PR does just that, and
yarn test
tests all pass after the version bump. Presumably this wouldn't cause regressions, then.I fully recognize this isn't a Gatsby-specific issue... it's probably a webpack issue from what I can tell, but I'm new enough to node that I don't have a solid grasp on yarn workspaces and dependency resolution.
Anyways, thanks for your consideration!
Documentation
Related Issues