Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump file-loader dependency to latest (6.1.0) #27224

Closed
wants to merge 1 commit into from

Conversation

taylorreece
Copy link

Description

I'm having issues with a yarn workspaces environment that hosts both a gatsby-based site, and a https://github.com/facebook/docusaurus site. Gatsby and Docusaurus install different versions of a dependency, file-loader. Gatsby installs 1.1.11 from 3 years ago, and Docusaurus installs 6.0.0.

For some yarn-workspaces related reason that I don't fully understand, Docusaurus then winds up importing the older dependency that Gatsby specifies (facebook/docusaurus#3515) rather than the one that it specifies. This results in my Docusaurus site not being able to build, but if I remove the Gatsby project, the Docusaurus site builds fine.

I was curious if we could please bump the Gatsby dependency on file-loader? This PR does just that, and yarn test tests all pass after the version bump. Presumably this wouldn't cause regressions, then.

I fully recognize this isn't a Gatsby-specific issue... it's probably a webpack issue from what I can tell, but I'm new enough to node that I don't have a solid grasp on yarn workspaces and dependency resolution.

Anyways, thanks for your consideration!

Documentation

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 1, 2020
@ascorbic ascorbic added topic: webpack/babel Webpack or babel and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 2, 2020
@ascorbic
Copy link
Contributor

ascorbic commented Oct 2, 2020

Hi. Thanks for this PR. We need to be a bit cautious here, as we've not updated this loader in several years, and this bumps it by five major versions. There are several breaking changes listed, and they might not be caught by our automated test. We need to investigate how we can appropriately test it.

@ascorbic ascorbic added status: needs core review Currently awaiting review from Core team member breaking change If implemented, this proposed work would break functionality for older versions of Gatsby labels Oct 2, 2020
@taylorreece
Copy link
Author

Closing this out for now, as I realized that it won't actually fix my issue and those 5 major version bumps are probably more than a dummy like me can handle. Thanks for the great package - Gatsby rocks!

@taylorreece taylorreece closed this Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change If implemented, this proposed work would break functionality for older versions of Gatsby status: needs core review Currently awaiting review from Core team member topic: webpack/babel Webpack or babel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants