Signal pallet from scratch

[vovacha]

The Signal pallet was created from scratch #65

Interface changes:

• One extrinsic for all proposal types.
• One extrinsic for all voting types.

New features:

• spending proposal #22
• signal: add a deposit to proposal as collateral #62
• Automated slashing.
• Scheduled proposal activation, if start > current block (Created -> Activated).
• Majority types (Simple, Relative, Absolute) General Proposal + determine Majority gamedao-haiku#108
• Voting power: Unit (Person, Token), Scale (Linear, Quadratic).
• Quorum.
• Token weighted voting.
• MultiCurrency support for Withdrawal and Spending proposals (Flow Campaigns still don't support it).
• Early finalization: Absolute majority > 50% or everybody voted.
• Add validation for voting: org members allowed for General or Spending proposals, and campaign contributors allowed for Withdrawal proposals.

Other changes:

• Storage reduced from 27 to 6 items SBP: Signal #57
• Naming changes for Events (I was inspired by FRAME pallets) - could be a discussion.
• Types changes
• Tests, mocks, benchmarks, weights.

Next steps:

• Create documentation - in progress.
• Flow pallet: add support for multiple currencies Add multi-currency support for Flow pallet #70
• Testing approach should be reconsidered since its current implementation has too much of repeated code (create test framework, refactor, etc.).
• on_finalize seems to be heavy. Find out the proper value for MaxProposalsPerBlock
• Add docs. Some are missing.
• Multiple options/choices voting - this is not ready yet. Medium size task up to 5 SP.

Extrinsics:

pub fn proposal(
	origin: OriginFor<T>,
	proposal_type: ProposalType,
	org_id: T::Hash,
	title: BoundedVec<u8, T::StringLimit>,
	cid: BoundedVec<u8, T::StringLimit>,
	expiry: T::BlockNumber,
	majority: Majority,
	unit: Unit,
	scale: Scale,
	// Optional params:
	start: Option<T::BlockNumber>,
	quorum: Option<Permill>,
	deposit: Option<T::Balance>,
	// Optional proposal specific params:
	campaign_id: Option<T::Hash>,
	amount: Option<T::Balance>,
	beneficiary: Option<T::AccountId>,
	currency_id: Option<T::CurrencyId>,
)

pub fn vote(
	origin: OriginFor<T>,
	proposal_id: T::Hash,
	approve: bool,
	deposit: Option<T::Balance>,
) 

[vovacha]

After the recent discussion, the Spending proposal logic should be changed.

• remove Failed proposal status -> should be Finalized instead
• add funds reserving on proposal start
• transfer reserved funds at the end

I am switching PR to draft.

[vayesy]

Good job! 👍

[2075]

good job 👌

[vovacha]

Wrong target branch, changes reverted. New PR #79