Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nft metadata #147

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Update nft metadata #147

merged 2 commits into from
Mar 17, 2023

Conversation

FiberMan
Copy link
Contributor

  • Allow Bot to call update_battlepass extrinsic.
  • Update collection metadata if new CID provided in update_battlepass or update_reward extrinsics.
  • Optional CID parameter added for claim_battlepass and claim_reward extrinsics. If provided, it will be stored in NFT metadata. Otherwise, the CID of Battlepass/Reward will be stored.
  • Removed ability to claim Reward for oneself, if it is not a Prime or Bot.

@FiberMan FiberMan requested review from 2075 and vayesy March 16, 2023 11:43
@FiberMan FiberMan self-assigned this Mar 16, 2023
2075
2075 reviewed Mar 16, 2023
View reviewed changes
battlepass/src/lib.rs Outdated Show resolved Hide resolved
2075
2075 approved these changes Mar 16, 2023
View reviewed changes
battlepass/src/lib.rs Outdated Show resolved Hide resolved
@2075 2075 mentioned this pull request Mar 16, 2023
Closed
2 tasks
vayesy
vayesy reviewed Mar 16, 2023
View reviewed changes
battlepass/src/lib.rs Outdated Show resolved Hide resolved
battlepass/src/lib.rs Outdated Show resolved Hide resolved
@FiberMan FiberMan force-pushed the update-nft-metadata branch from 69129f9 to 2cc4c03 Compare March 16, 2023 16:14
@2075 2075 changed the base branch from release-1.3.0 to dev March 16, 2023 19:04
@2075
Copy link
Member

2075 commented Mar 16, 2023

@FiberMan @vayesy do we merge the current 1.3.0 into dev as ongoing, then this pr will also merge towards dev?

@vayesy vayesy changed the base branch from dev to release-1.3.0 March 17, 2023 09:43
@vayesy vayesy merged commit 87c0101 into release-1.3.0 Mar 17, 2023
@vayesy vayesy deleted the update-nft-metadata branch March 17, 2023 10:34
@vayesy vayesy mentioned this pull request Mar 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vayesy vayesy vayesy approved these changes

@2075 2075 2075 approved these changes

Assignees

@FiberMan FiberMan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FiberMan @2075 @vayesy