Add levels and rewards to battlepass #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vayesy
reviewed
Dec 27, 2022
| /// RewardStates: map Hash => RewardState | ||
| #[pallet::storage] | ||
| #[pallet::getter(fn get_reward_state)] | ||
| pub(super) type RewardStates<T: Config> = StorageMap<_, Blake2_128Concat, T::Hash, RewardState, OptionQuery>; |
There was a problem hiding this comment.
Why not replace this with state field in Reward struct?
There was a problem hiding this comment.
It will not be so efficient if we'll need to update only the state in the struct. See this.
There was a problem hiding this comment.
what does it exactly store? if it is the result of completing a quest, then the possession of the resulting nft is already a proof.
There was a problem hiding this comment.
Do you mean RewardStates? It stores the state of the Reward. Battlepass owner creates Rewards. When user claims the Reward it will mint NFT and add a record to the ClaimedRewards storage.
2075
reviewed
Dec 29, 2022
| }, | ||
|
|
||
| /// Achievement level added for Battlepass | ||
| LevelAdded { |
There was a problem hiding this comment.
these two events are the same, so we can do a LevelUpdated no?
There was a problem hiding this comment.
I think it's better to distinguish those events. There is no level state, it just exists or not. So LevelUpdated may not be so clear in this case.
There was a problem hiding this comment.
It's about a list of levels (mapping) for Battlepass. E.g.:
Level 1 -> 100 points
Level 2 -> 200 points
Level 3 -> 300 points
If you want to remove Level 3, you can't just --3.
2075
approved these changes
Dec 29, 2022
2075
added a commit
that referenced
this pull request
May 1, 2024
* Remove unused migration. (#111) * Remove unused migration. * Remove empty migration.rs files * Fix tests. * Add M2 review comments * USE ORML dependencies from github instead of local version * fix: rm warnings * M2 review fixes (#115) * feat: update member state (#119) * feat: update orml references to git * feat: add update member ext * feat: update missing member state * feat: update event, api * Updated extrinsic. Added benchmarks Co-authored-by: vasylenko-yevhen <[email protected]> * feat: battlepass (#120) * Create Battlepass pallete * docs: add readme * Update extrinsics. * Add RMRK integration, mint Battlepass NFTs. Co-authored-by: 2075 <[email protected]> * Allow users to join to prime type org (#121) * Create Battlepass pallete * Add Battlepass activation, refactor. * Update lib.rs (#123) * add levels and rewards to battlepass. (#124) * Unit tests for Battlepass (#125) * Add wallet for battlepass Bot * feat: change root_or_governance for approval * feat: benchmarks for battlepass * feat: bump substrate version from 0.9.28 to 0.9.36 * Add extrinsic descriptions for Battlepass. * feat: Update Battlepass and Reward (#130) * feat:tests for update_battlepass and update_reward * feat: new benchmarks for battlepass. * feat: extend bot privileges * feat: claim battlepass by bot * feat: add, remove levels by bot * update benchmarks * feat: use unique NFT IDs * feat: remove ability to claim battlepass for self * allows non org members to participate in battlepass * finish tests, update weights * allows root account to add bot account to the battlepass * Correctly validate `add_bot` caller * fix: update_battlepass should update any number of fields * Remove RMRK * fix: should create battlepass if there is active one * feat: add option for name and cid (#142) * feat: add option for name and cid * feat: update tests * feat: add mock, update test * feat: fix types * feat: rm unused * feat: update readme, benchmarking * Fix type --------- Co-authored-by: vasylenko-yevhen <[email protected]> * feat: bump substrate version from 0.9.36 to 0.9.38 (#141) * feat: bump substrate version from 0.9.36 to 0.9.38 * bump protocol to 1.3.0 * use CID as collection metadata * Revert "feat: bump substrate version from 0.9.36 to 0.9.38 (#141)" (#144) This reverts commit d084aca. * Update substrate v36 to v38 (#145) * feat: bump substrate version from 0.9.36 to 0.9.38 * bump protocol to 1.3.0 * use CID as collection metadata --------- Co-authored-by: FiberMan <[email protected]> * fix: update_reward should update any number of fields (#146) * feat: allow bot to update the battlepass * feat: use provided CID as a metadata for NFT. * address comments from SBP3 review * Substrate upgrade 0.9.38 to 0.9.39 * Substrate upgrade 0.9.39 to 0.9.40 * remove deprecated macros * replace pallet_uniques with pallet_nfts (#152) * fix(battlepass): update permissions (#153) --------- Co-authored-by: Yura <[email protected]> Co-authored-by: Daniel Bigos <[email protected]> Co-authored-by: vasylenko-yevhen <[email protected]> Co-authored-by: 2075 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.