Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the fork of flag to gaia-pipeline instead of my personal one. #106

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

Skarlso
Copy link
Member

@Skarlso Skarlso commented Sep 4, 2018

It just occurred to me that using my personal fork is not the best thing for Gaia project in general. So I switched it to the Organization's fork.

@Skarlso Skarlso added the Ready To Merge PR is ready to be merged into master label Sep 4, 2018
@Skarlso Skarlso requested a review from michelvocks September 4, 2018 12:18
@Skarlso Skarlso changed the title Change the fork of flag to gaia-pipeline instead of my personal fork. Change the fork of flag to gaia-pipeline instead of my personal one. Sep 4, 2018
@codecov-io
Copy link

Codecov Report

Merging #106 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   64.67%   64.57%   -0.11%     
==========================================
  Files          22       22              
  Lines        1911     1911              
==========================================
- Hits         1236     1234       -2     
- Misses        539      540       +1     
- Partials      136      137       +1
Impacted Files Coverage Δ
scheduler/scheduler.go 73.83% <0%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add96f7...aa28bf2. Read the comment docs.

Copy link
Member

@michelvocks michelvocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@michelvocks michelvocks merged commit 664e220 into gaia-pipeline:master Sep 4, 2018
michelvocks pushed a commit to michelvocks/gaia that referenced this pull request Sep 10, 2018
michelvocks added a commit that referenced this pull request Sep 24, 2018
* Added tests for plugin. Implemented job results feature

* Removed unnecessary return statement. Fixed timeout test

* Fixed wrong comments and error messages

* Fixed typo in variable name

* Fixed segmentation violation exception.

* Fixed wrong behavior when pipeline should safely exit

* Change the fork of flag to gaia-pipeline instead of maintainer personal fork. (#106)

* Added extra check if pipeline has no jobs (#102)

* Fixed missing status in test

* Fixing stuck job after it failed.

* Working.

* Fixed wrong pointer to worload object. Fixed safe exit of pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge PR is ready to be merged into master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants