Seqref updates #573
Seqref updates #573
Conversation
| $ref: "#/$defs/SequenceString" | ||
| description: >- | ||
| A :ref:`SequenceString` that is a literal representation of the referenced sequence. | ||
| moleculeType: |
There was a problem hiding this comment.
@cmprocknow concern about "molecule type"; perhaps "molecularContext" would be cleaner.
There was a problem hiding this comment.
I think we can sort this out during public review.
There was a problem hiding this comment.
RefSeq calls this Molecule Type, so seems appropriate to keep.
| moleculeType: | ||
| type: string | ||
| enum: | ||
| - genomic |
There was a problem hiding this comment.
general discussion on genomic expressed concerns, possible alternate is "template"
There was a problem hiding this comment.
except "template" is a total non-starter. There are genomic variants that are not necessarily going to be involved as template sequence (e.g. variants in regulatory elements)
There was a problem hiding this comment.
Group consensus: we should cover the same concept types that RefSeq uses.
schema/vrs/def/SequenceReference.rst
Outdated
| - | ||
| - {'$ref': '#/$defs/sequenceString'} | ||
| - 0..1 | ||
| - A :ref:`SequenceString` that is a literal representation of the referenced sequence. |
There was a problem hiding this comment.
This should be lowercase sequenceString...
| - A :ref:`SequenceString` that is a literal representation of the referenced sequence. | ||
| * - moleculeType | ||
| - | ||
| - string |
There was a problem hiding this comment.
MappableConcept? or are you good with an enum here? I defer to your judgement on this. I almost think we should avoid introducing MappableConcept into VRS unless it really needs to happen.
There was a problem hiding this comment.
forget this. enum works for this one.
| $ref: "#/$defs/SequenceString" | ||
| description: >- | ||
| A :ref:`SequenceString` that is a literal representation of the referenced sequence. | ||
| moleculeType: |
There was a problem hiding this comment.
I think we can sort this out during public review.
| moleculeType: | ||
| type: string | ||
| enum: | ||
| - genomic |
Addresses #567 and #568. For discussion.