Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parallel file validation for a datapackage #1722

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pierrecamilleri
Copy link
Collaborator

I think I have identified what breaks the parallel validation of a datapackage : in validator.py, Resource is imported as a type, but then used as a class to retrieve a class method. (Resource.from_descriptor)

Importing Resource leads to a circular import. A small workaround is to import Resource locally, but this is not very satisfactory.

Todo : 

  • Test that it works correctly
  • Check why the tests did not intercept this error
  • See if I can find a more elegant way to deal with the circular import. I actually don't see the benefit of having this validator.py class instead of dispatching the methods to Resource and DataPackage directly, but I may have missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding --parallel CLI flag breaks validation
1 participant