fix: github adapter only applies to URLs formatted as expected #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdelboca
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Looks good @pierrecamilleri .
Personally I like early returns in methods (so +1!), they make the overall logic of the method easier to follow since you automatically discard scenarios in your mind 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the absence of other hints (e.g. a Controller object associated to another plugin), all URLs from
github.conef.ukwere being processed by theGithubPlugin, to create a Github Data Portal adapter.With this PR,
GithubPluginonly handles the URL if it has the expected format "https://github.com/user_or_org/repo", and "https://github.com/user_or_org", otherwise it is passed other to be treated as a plain URL.I also made some refactorings along the way, to have more readable and less nested code.
As tests github portal are currently skipped, I checked manually that I have not broken this functionality.