Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CFF #1695

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Adds CFF #1695

merged 6 commits into from
Nov 7, 2024

Conversation

sapetti9
Copy link
Contributor

Adds citation file format in order to make it easier to cite the Frictionless Python Framework in academic publications. @peterdesmet please have a look and see what you think.

  • fixes #<1693>

cc @pierrecamilleri & @roll -- I added your email too, but please remove it if you don't wish for it to be here.

@sapetti9 sapetti9 requested a review from peterdesmet October 22, 2024 21:12
CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Show resolved Hide resolved
@roll
Copy link
Member

roll commented Oct 28, 2024

Great work @sapetti9 !

@sapetti9 sapetti9 mentioned this pull request Oct 28, 2024
@pierrecamilleri
Copy link
Collaborator

Thanks !

Not sure what is happening with the CI though, I'm looking into it.

@pierrecamilleri
Copy link
Collaborator

pierrecamilleri commented Oct 30, 2024

Still not clear what exactly happened but it seems to be a regression linked to sqlalchemy and/or duckdb (see for instance here, but I could not find a relevant associated duckdb issue) see edit.

I try to fix this quickly by pinpointing the versions.

EDIT : I think I found the issue

sapetti9 and others added 6 commits November 7, 2024 12:50
Adds citation file format in order to make it easier to cite the Frictionless Python Framework in academic publications
Thanks @peterdesmet, this looks much better now. I've left @roll's affiliation as an open question to him, and lets start a separate discussion about the description.

Co-authored-by: Peter Desmet <[email protected]>
Updating Evgeny's affiliation
@pierrecamilleri
Copy link
Collaborator

Issue solved, thanks for your patience !

@peterdesmet
Copy link
Member

peterdesmet commented Nov 7, 2024

Great! @sapetti9 or @pierrecamilleri can you merge this?

@sapetti9 sapetti9 merged commit e94ecb0 into main Nov 7, 2024
9 checks passed
@sapetti9 sapetti9 deleted the sapetti9-patch-1 branch November 7, 2024 15:17
@sapetti9
Copy link
Contributor Author

sapetti9 commented Nov 7, 2024

Done. Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants