fix: Skip WIP Warehouse transfer #45200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihir-kandoi
commented
Jan 10, 2025
| @@ -1634,7 +1634,6 @@ def test_reserve_sub_assembly_items(self): | |||
| for d in work_orders: | |||
| wo_doc = frappe.get_doc("Work Order", d.name) | |||
| wo_doc.skip_transfer = 1 | |||
| wo_doc.from_wip_warehouse = 1 | |||
There was a problem hiding this comment.
Why was this put here when skip_transfer is set to 1 just above this line?
mihir-kandoi
commented
Jan 10, 2025
| @@ -1704,7 +1704,6 @@ def test_so_back_updated_from_wo_via_mr(self): | |||
| wo_name = raise_work_orders(mr.name)[0] | |||
| wo = frappe.get_doc("Work Order", wo_name) | |||
| wo.wip_warehouse = "Work In Progress - _TC" | |||
| wo.skip_transfer = True | |||
There was a problem hiding this comment.
why was skip_transfer set to True just after setting WIP warehouse?
|
This PR is completely incorrect. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference support ticket: 29053
WIP warehouse field was not being removed even when "Skip Material Transfer to WIP Warehouse" was enabled. This simple PR fixes that.
no-docs