feat: BOM now explodes items based on both item_code AND item_name #45188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihir-kandoi
commented
Jan 10, 2025
| se.items[0].stock_uom = "Kg" | ||
| se.save() | ||
|
|
||
| self.assertEqual(se.items[0].item_name, item.item_name) |
There was a problem hiding this comment.
@rohitwaghchaure this is possible very very wrong because I am removing an assert/test.
In this PR, I have removed the behaviour where user would change item_name and it would be reset back to the item_name from its Item document. I could not find this being used anywhere else but still not sure if this would break things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue: #44043
Current behaviour:
Upon saving a BOM, exploded items were computed based on only the item_code. If 2 items with same item_code but different item_name were added, ERPNext would merge them into 1.
New behaviour:
Now when user saves a BOM, ERPNext will check if both item_code and item_name fields are same and only then merge them.
no-docs