Add stop button in editor title bar #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the stop button looks funny on windows 😂
|
|
You mean the maximize window button? I developed this on Windows and wasn't phased by it, but I see what you mean. The square is a pretty universal stop button as far as know, so I'm not sure what we would change it to. An "X" could work but then that looks just like the close window button. Any suggestions for an alternative icon? |
|
unfortunately, i don't have
…On Sun, Jul 11, 2021, 6:17 AM Chap Callanan ***@***.***> wrote:
You mean the maximize window button? I developed this on Windows and
wasn't phased by it, but I see what you mean.
The square is a pretty universal stop button as far as know, so I'm not
sure what we would change it to. An "X" could work but then that looks just
like the close window button.
Any suggestions for an alternative icon?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#776 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARBP6AURMPJQIZEOKPNICFDTXDPKRANCNFSM43PUXD3A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "Stop code run" button in the editor title bar that appears when code is running.
The button can be turned off with the configuration option "code-runner.showStopIconInEditorTitleMenu", which is set to True by default.