Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no infinite running command notification for diff file and folder commands #5722

Merged
merged 4 commits into from
Aug 14, 2024
Merged

fix: no infinite running command notification for diff file and folder commands #5722

merged 4 commits into from
Aug 14, 2024

Conversation

CristiCanizales
Copy link
Contributor

What does this PR do?

Gets rid of the Running SFDX: Diff File Against Org notification when the diff source fails.

What issues does this PR fix or reference?

@W-16006725@

Functionality Before

  • Running notification even when the command already failed
image

Functionality After

  • Only failure notifications when it fails
image

@CristiCanizales CristiCanizales self-assigned this Aug 13, 2024
@CristiCanizales CristiCanizales requested a review from a team as a code owner August 13, 2024 23:44
daphne-sfdc
daphne-sfdc approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@daphne-sfdc daphne-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🎉

  1. Diff file not present in the org ✅
Screenshot 2024-08-14 at 8 08 17 AM
  1. Diff folder with no files present in the org ✅
Screenshot 2024-08-14 at 1 20 53 PM
  1. Diff folder with some files present in the org -> only the files that are present in the org are listed in the diff ✅

@CristiCanizales CristiCanizales merged commit 7d5da12 into develop Aug 14, 2024
12 checks passed
@CristiCanizales CristiCanizales deleted the cristi/infinite-notif-diff branch August 14, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daphne-sfdc daphne-sfdc daphne-sfdc approved these changes

@peternhale peternhale peternhale approved these changes

Assignees

@CristiCanizales CristiCanizales

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CristiCanizales @peternhale @daphne-sfdc