Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove Dependencies Causing Install Issues on M1 (electron, spectron) #4723

Merged

Conversation

klewis-sfdc
Copy link
Contributor

What does this PR do?

  • On a recently re-imaged M1 Mac, I am unable to install with the following error.
  • This PR unblocks my current build on M1 by removing the offending dependency (that is no longer used by VSCE anyway)

`npm ERR! code 1
npm ERR! path /Users/kenneth.lewis/dev/salesforcedx-vscode/node_modules/electron-chromedriver
npm ERR! command failed
npm ERR! command sh -c node ./download-chromedriver.js
npm ERR! /Users/kenneth.lewis/dev/salesforcedx-vscode/node_modules/electron-chromedriver/download-chromedriver.js:19
npm ERR! if (err != null) throw err
npm ERR! ^
npm ERR!
npm ERR! Error: Failed to find Electron v7.0.0 for darwin-arm64 at https://github.com/electron/electron/releases/download/v7.0.0/chromedriver-v7.0.0-darwin-arm64.zip
npm ERR! at Request. (/Users/kenneth.lewis/dev/salesforcedx-vscode/node_modules/nugget/index.js:197:61)
npm ERR! at Request.emit (node:events:513:28)
npm ERR! at Request.onRequestResponse (/Users/kenneth.lewis/dev/salesforcedx-vscode/node_modules/request/request.js:1059:10)
npm ERR! at ClientRequest.emit (node:events:513:28)
npm ERR! at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:693:27)
npm ERR! at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
npm ERR! at TLSSocket.socketOnData (node:_http_client:534:22)
npm ERR! at TLSSocket.emit (node:events:513:28)
npm ERR! at addChunk (node:internal/streams/readable:315:12)
npm ERR! at readableAddChunk (node:internal/streams/readable:289:9)

npm ERR! A complete log of this run can be found in:
npm ERR! /Users/kenneth.lewis/.npm/_logs/2023-03-01T23_53_44_689Z-debug-0.log`

What issues does this PR fix or reference?

@W-12626905@

Functionality Before

  • Can't build on local M1 Mac currently (as recently as yesterday I was able to successfully build with this same machine pre-re-image)

Functionality After

  • M1 Mac build succeeds

@klewis-sfdc klewis-sfdc requested a review from a team as a code owner March 2, 2023 05:43
@klewis-sfdc klewis-sfdc requested a review from RitamAgrawal March 2, 2023 05:43
@klewis-sfdc klewis-sfdc merged commit cc6f28b into develop Mar 2, 2023
@klewis-sfdc klewis-sfdc deleted the ken/W-12626905--fix-M1-build-issues-system-tests-deps-2 branch March 2, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant