-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Allow import of vscode-util from other modules. #4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is the collection of changes needed to enable having the ability to expose the vscode-utils module as a single module in order to enable us to have a single location for core v3 updates.
How to Review
Mark this down..this is the only time you'll hear this from me...do NOT review this PR. It's too big. In order to make reviewing the changes simpler I have broken this PR apart into the following:
#4427 ✅
#4428 ✅
#4429 ✅
#4430 ✅
#4431 ✅
#4432 ✅
#4433 ✅
(please review those PRs). Note those PRs will not build or run locally. If you would like to verify the change please use the branch associated with this PR gbockus/allow-utils-in-faux-4
Changes found in this PR:
How will this merge?
After getting approval on the associated PRs I will incorporate any feedback and pull it into this branch. This branch is currently building successfully. We as a team can test that it is behaving property (@RitamAgrawal and I have built and run it locally successfully)
I will touch base in slack and merge after I have sign off from the team.
Tickets to be created as follow on work from review
"useUnknownInCatchVariables": false
setting from the tsconfig