-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support checkpoints for one-step replay debugger #3410
feat: support checkpoints for one-step replay debugger #3410
Conversation
packages/salesforcedx-vscode-apex-replay-debugger/src/breakpoints/checkpointService.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment, otherwise it looks good!
What's the behavior if you don't have any checkpoints? Do we still need to run this command? Is it possible to check whether checkpoints are present beforehand? |
Thank you for reviewing, Ananya! We discussed in one of our daily syncs and decided to close @W-7748717@ because the debug & run command should actually not give warnings (should just run through the test) if there is no checkpoint/breakpoint. We use |
What does this PR do?
As part of the one-step replay debugger command, this PR checks for the presence of checkpoints. If they are present, this PR uploads them before we execute the Apex Test(s). Checkpoints have a limit of 5 per org/user, if the limit is exceeded, the command execution would be canceled and a message indicating this limit violation would be shown to the user.
What issues does this PR fix or reference?
@W-7757402@
Functionality Before
The one-step replay debugger command did not support checkpoints.
Functionality After
The one-step replay debugger command uploads checkpoints if they are present.
If there are more than five checkpoints, the command executed is canceled and a message is reported to the user.