feat: separate plugin-templates from this repository #520
Conversation
Changed the monorepo to a single repo. The plugin has been moved to https://github.com/salesforcecli/plugin-templates. BREAKING CHANGE: The plugin is no longer available here.
| @@ -41,6 +41,7 @@ | |||
| "chai": "^4.2.0", | |||
| "chai-as-promised": "^7.1.1", | |||
| "commitizen": "^4.2.4", | |||
| "cz-conventional-changelog": "^3.3.0", | |||
There was a problem hiding this comment.
Is this something I should also add to the apex-node library?
| }, | ||
| "engines": { |
There was a problem hiding this comment.
You should probably put engines back.
| @@ -11,6 +11,7 @@ | |||
| "outDir": "./lib", | |||
| "preserveConstEnums": true, | |||
| "strict": true, | |||
| "allowSyntheticDefaultImports": true, | |||
There was a problem hiding this comment.
did something change resulting in this addition?
There was a problem hiding this comment.
this was present in the original templates-level file that I had moved to the top level, so I think the diff view is a little confused: https://github.com/forcedotcom/salesforcedx-templates/blob/8cb2f51d25a054db61891c52f5ad24802677ce1c/packages/templates/tsconfig.json
.nycrc
Outdated
| "nyc": { | ||
| "extends": "@salesforce/dev-config/nyc" |
There was a problem hiding this comment.
this was also present at the templates-level initially! I think Willie had added it in a previous PR
There was a problem hiding this comment.
And to actually answer the question ... no. https://github.com/forcedotcom/dev-config/blob/main/nyc.json
I'm thinking I might want to revert in that case?
There was a problem hiding this comment.
yeah agreed, probably want to go with what we had originally
There was a problem hiding this comment.
Ran though the PR as best I could and had a couple of trivial suggestions. Pulled local and verified all the build pieces. Only issue is lint isn't working currently
question Which command would you like to run?: lint
$ eslint -c .eslintrc.json --ext .ts ./src ./test
Oops! Something went wrong! :(
ESLint: 7.32.0
ESLint couldn't find the config "../.eslintrc.js" to extend from. Please check that the name of the config is correct.
The config "../.eslintrc.js" was referenced from the config file in "/Users/gbockus/github/PDT/salesforcedx-templates/test/.eslintrc.js".
If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ansible|gbockus-ltm at ~/github/PDT/salesforcedx-templates ±(randi/remove-plugin) ❯```
I think we get lint fixed and we're good to go 👍
| "node": ">=14.17.0" | ||
| "resolutions": { | ||
| "yeoman-generator": "^5.6.1", | ||
| "@types/yeoman-generator": "^5.2.9" |
There was a problem hiding this comment.
this may no longer be necessary
There was a problem hiding this comment.
I would be super nervous to remove yeoman in here... do you think it's not necessary because it was used in plugin-templates mostly before?
There was a problem hiding this comment.
This is just the resolutions block. It basically ties us & the deps to a version of yeoman. It's fine we can leave it.
|
@gbockus-sf linting error was fixed - also I don't think linting was running automatically and I got a ton of errors when I ran the command, so I fixed those too. I'll look into seeing if we can get it to run on commits like we do with vs code. |
package.json
Outdated
| "./{src,test}/**/*.{ts,js}": [ | ||
| "eslint -c .eslintrc.json --fix" | ||
| ] | ||
| "husky": { |
There was a problem hiding this comment.
ok so adding this was pretty cool. We now get the following when we commit, and then a full lint + test happened on push!
| "text", | ||
| "lcov" | ||
| ], | ||
| "reporter": ["text", "lcov"], |
There was a problem hiding this comment.
This is part of the commit hook now, so it stays this way
What does this PR do?
Removes the plugin-templates library from this repository. Plugin-templates will now be a stand-alone repository here.
What issues does this PR fix or reference?
@W-11309541@