Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Checkbox] toggle don't have the "checked" class when initialized in a 'checked' state #85

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Conversation

ColinFrick
Copy link
Member

Previously it only worked if fireOnInit was set to true (default is false)
Behaviour of fireOnInit was not modified: the callbacks are only called on initial load when fireOnInit is true

Closed Issues

Semantic-Org/Semantic-UI#2506

Previously it only worked if fireOnInit was set to true (default is false)
Behaviour of fireOnInit was not modified: the callbacks are only called on initial load when fireOnInit is true

Was reported in Semantic-Org/Semantic-UI#2506
@ColinFrick ColinFrick added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript labels Aug 13, 2018
@ColinFrick ColinFrick added this to the 2.5 milestone Aug 13, 2018
@ColinFrick ColinFrick requested review from prudho and y0hami August 13, 2018 10:48
@ColinFrick ColinFrick added the state/awaiting-reviews Pull requests which are waiting for reviews label Aug 13, 2018
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Aug 13, 2018
@y0hami y0hami merged commit d887f7a into fomantic:beta Aug 13, 2018
@ColinFrick ColinFrick deleted the fix-2506 branch August 17, 2018 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants