feat: add go router package and routing to the app #1401
+955
−526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasleyba
requested changes
Jan 6, 2025
| import 'package:flutter_news_example/home/home.dart'; | ||
| import 'package:flutter_news_example/login/login.dart'; | ||
| import 'package:flutter_news_example/magic_link_prompt/view/magic_link_prompt_page.dart'; |
There was a problem hiding this comment.
It would be great to be able to use barrel files instead of importing the file directly.
There was a problem hiding this comment.
check other imports too
| final id = state.pathParameters['id']; | ||
|
|
||
| final isVideoArticle = bool.tryParse( | ||
| state.uri.queryParameters['isVideoArticle'] ?? 'false', |
There was a problem hiding this comment.
state.uri.queryParameters can be abstracted as a variable to reuse
| : null; | ||
|
|
||
| if (id == null) { | ||
| throw Exception('Missing required "id" parameter'); |
There was a problem hiding this comment.
What's shown when this happens ? Isn't better to render NetworkError instead?
| @@ -31,6 +33,17 @@ class HomeView extends StatelessWidget { | |||
| } | |||
| }, | |||
| ), | |||
| BlocListener<AppBloc, AppState>( | |||
There was a problem hiding this comment.
BlocListener<CardActivationCubit, CardActivationState>(
listenWhen: (_, current) => current == AppStatus.onboardingRequired ,
listener: (context, _) => context.goNamed(OnboardingPage.routePath),
),
Something like this could be simpler, what do you think?
| @@ -40,7 +45,7 @@ void main() { | |||
|
|
|||
| testWidgets('renders FeedView', (tester) async { | |||
| await tester.pumpApp( | |||
| const HomePage(), | |||
| InheritedGoRouter(goRouter: router, child: const HomePage()), | |||
There was a problem hiding this comment.
Why is InheritedGoRouter necessary?
There was a problem hiding this comment.
I don't think we should remove these tests, but adapt them to the new approach to navigation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Routing refactored now using go_router package.
TO DO:
Demo videos
Profile, Notification preferences and Subscriptions page:
1.mov
Article page, slideshow and Subscriptions page:
2.mov
Login flow
4.mov
Article details
3.mov
Type of Change