-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New router #524
New router #524
Conversation
Pull Request Test Coverage Report for Build 3546
💛 - Coveralls |
…s available from a given starting edge
valid way of representing the route in a more probabilistic setting | ||
is: | ||
|
||
>>> def specify_routes(self, net_params): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give a more representative example of this case? Perhaps something like:
"top-random": [
(["top", "left", "bottom", "right"], 0.9)
(["top", "right", "bottom", "left"], 0.1)
],
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
'human_2', and 'human_3'. Then, an appropriate definition of the | ||
routes may look something like: | ||
|
||
>>> def specify_routes(self, net_params): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is differentiating this use case with the first one? Maybe I have missed it but how is it decided which way the specify_routes
method will be parsed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a comment in the end about it
@AboudyKreidieh Is it possible to merge this? (I can help with this PR if needed) It would be super useful to have non-deterministic routes for the i-210! |
This PR introduces a new method for specifying multiple routes from a given starting edge. Routes now can be specified in one of three ways (as documented in the the scenario class):