Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token field for exact app matches #77

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

jameswestman
Copy link
Collaborator

Adds an apps field to repo tokens. has_token_prefix checks it in addition to the prefixes field, but only for exact matches. This will allow us to, for example, give access to an app but not its extensions.

jameswestman added a commit to jameswestman/website that referenced this pull request Oct 19, 2022
"repos" is not the correct field for app IDs. It should be "apps", which
is added in <flatpak/flat-manager#77>.
razzeee pushed a commit to flathub-infra/website that referenced this pull request Oct 19, 2022
"repos" is not the correct field for app IDs. It should be "apps", which
is added in <flatpak/flat-manager#77>.
@jameswestman
Copy link
Collaborator Author

cc @danielsilverstone-ct

Copy link

@danielsilverstone-ct danielsilverstone-ct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise I think this is fine - I made a few code suggestions, but I'm comfortable if none of them are taken.

src/api.rs Outdated Show resolved Hide resolved
src/api.rs Outdated Show resolved Hide resolved
src/api.rs Show resolved Hide resolved
@barthalion barthalion merged commit f04c7d5 into flatpak:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants