repo: Allow /s in repo names #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbnicholson
force-pushed
the
repo-names-with-slash
branch
from
c53aad7 to
aa62329
Compare
|
I rebased this on master now and did a quick test. It seems to work correctly. @alexlarsson can you have a look? |
|
I landed the 1.0 conversion which changed this stuff so it needs rebasing. |
alexlarsson
reviewed
Dec 6, 2019
This was already determined above and nothing would have caused it to change.
dbnicholson
force-pushed
the
repo-names-with-slash
branch
from
aa62329 to
687e810
Compare
|
I think this is better. I had originally done the backwards scan with the idea that you wouldn't want to inadvertently match the wrong repo, but the repos can't be nested, so a forward search is all that's needed. |
alexlarsson
reviewed
Dec 10, 2019
alexlarsson
reviewed
Dec 10, 2019
At Endless we have repos organized into staging subdirectories, but the repo resource was only allowing a single path element. This changes the parameter to a single glob and then walks backwards to find a repo name that matches a path prefix.
dbnicholson
force-pushed
the
repo-names-with-slash
branch
from
687e810 to
e1bfa40
Compare
|
3rd times a charm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Endless we have repos organized into staging subdirectories, but the
repo resource was only allowing a single path element. This changes the
parameter to a single glob and then walks backwards to find a repo name
that matches a path prefix.