Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrated to newer version of lightning #165

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

aryankeluskar
Copy link
Contributor

Using the official migration guide available at this PR. The validation_epoch_end function was replaced with on_validation_epoch_end, so I updated the DeepBLAST class to ensure compatibility with pytorch-lightening and fixed the following error:

NotImplementedError: Support for `validation_epoch_end` has been removed in v2.0.0. 
`DeepBLAST` implements this method. You can use the `on_validation_epoch_end` hook instead. 
To access outputs, save them in-memory as instance attributes.

Additionally, I resolved a deprecation warning caused by the use of np.bool by switching to bool

@aryankeluskar aryankeluskar changed the title migrated to newer lightning and bool migrated to newer version of lightning Nov 6, 2024
@mortonjt
Copy link
Collaborator

Thanks, I'll merge and note that we are missing the validation metrics in a separate issue.

@mortonjt mortonjt merged commit ec661fa into flatironinstitute:master Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants