-
Notifications
You must be signed in to change notification settings - Fork 0
Notes about Reviews
Andrew Pope edited this page Oct 10, 2018
·
2 revisions
During a review, ensure to consider the following:
- Are the tests too specific. Unit tests should be testing functionality, not the structure of the code.
- Is it using comments to disable pylint or flake8 checks. Why?
- Does the code make sense?
- Does it strictly implement the goals of the parent issue.
- Are more elegant solutions immediately obvious? Less code is usually better.
- Complexity wise, is there anything with a ridiculous O value, such as O(n^3)?
- Is it possible to reduce the number of rows or columns being returned from the database? An example of this would be executing a
select * from table;
and then filtering by username in python.