Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Parser for jenny #2103

Merged
merged 81 commits into from
Oct 31, 2022
Merged

feat: Parser for jenny #2103

merged 81 commits into from
Oct 31, 2022

Conversation

st-pasha
Copy link
Contributor

@st-pasha st-pasha commented Oct 21, 2022

Description

This PR adds ability to parse Yarn files and create a YarnProject.
Not all syntaxes are covered yet, but a significant part is, and this should be enough to get started on creating a DialogueRunner.

This PR also renames the package into jenny / flame_jenny, as discussed in #2126.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • [-] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples or docs.

Breaking Change?

  • [-] Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, it's like its own little programming language

packages/flame_yarn/lib/src/parse/parse.dart Outdated Show resolved Hide resolved
@spydon spydon requested a review from a team October 21, 2022 16:56
@st-pasha st-pasha mentioned this pull request Oct 23, 2022
4 tasks
@spydon
Copy link
Member

spydon commented Oct 25, 2022

When having a look at this again, it seems like most of this code would be awesome as a separate package, since almost nothing so far seem specific to Flame, and then have the bridge package using that package (same structure as radiance will have once we get flame_radiance). Any reason that you put everything in here?

@st-pasha
Copy link
Contributor Author

The functionality works in stages: first we load the data from .yarn files and create an internal representation; then we use that representation in order to run the dialogue in a Flame game. The second part I'm still working on atm.

@st-pasha st-pasha changed the title feat: Parser for flame_yarn feat: Parser for jenny Oct 31, 2022
packages/flame_jenny/README.md Outdated Show resolved Hide resolved
packages/flame_jenny/jenny/README.md Outdated Show resolved Hide resolved
@spydon spydon enabled auto-merge (squash) October 31, 2022 21:39
@spydon spydon merged commit 4e4117c into main Oct 31, 2022
@spydon spydon deleted the ps.flame-yarn-parser branch October 31, 2022 21:45
@st-pasha st-pasha added the jenny Issues/PRs related to the Jenny package label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenny Issues/PRs related to the Jenny package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants