Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add children argument to SpriteComponent.fromImage #1793

Merged

Conversation

wolfenrain
Copy link
Contributor

@wolfenrain wolfenrain commented Jul 9, 2022

Description

Missing children argument on the named constructor.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@wolfenrain wolfenrain requested a review from a team July 9, 2022 19:40
@wolfenrain wolfenrain merged commit 80a6336 into main Jul 9, 2022
@wolfenrain wolfenrain deleted the feat/add-children-argument-to-sprite-component-from-image branch July 9, 2022 19:58
st-pasha pushed a commit to st-pasha/flame that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants