Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Documenting how to write documentation #1721

Merged
merged 11 commits into from
Jun 14, 2022

Conversation

st-pasha
Copy link
Contributor

Description

Since our documentation is fairly complex, we need to have a document which describes how various parts of it work. This PR adds such documentation.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • [-] I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples.

Breaking Change

  • [-] Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

doc/development/documentation.md Outdated Show resolved Hide resolved
doc/development/documentation.md Outdated Show resolved Hide resolved
@spydon spydon requested a review from a team June 12, 2022 15:42
@@ -0,0 +1,5 @@
# Development
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would Contributing be a better name? development could refer to game development in general

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On that topic; it would be nice to include the CONTRIBUTING.md file in this category too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we could eventually publish a variety of things here, such as

  • the main "contributing" guideline;
  • various policies;
  • schedule of future releases, and/or events (such as FlameCons);
  • mirror of the changelog, so that it is easier to find;
  • etc.

The term "development" seem to be more generic and capable of fitting more topics.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think development is fine as a topic, since contributing should refer to the specific contributing.md doc.

Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very meta!

@spydon spydon merged commit ea354e3 into flame-engine:main Jun 14, 2022
@st-pasha st-pasha deleted the ps/doc-on-doc branch June 14, 2022 18:34
st-pasha added a commit to st-pasha/flame that referenced this pull request Jun 18, 2022
Since our documentation is fairly complex, we need to have a document which describes how various parts of it work. This PR adds such documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants