Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added TextFormatter classes #1720
feat: Added TextFormatter classes #1720
Changes from 17 commits
d431d99
92b4060
15847f2
0e8eaf1
b347675
a8f5340
88e3e11
18a99d1
950c4b7
2a00d2c
4f3e6ba
e562ef4
68ff5d5
1efddcc
2b6953d
42acb74
b186cb2
991c942
9da5837
a0a0509
7121b19
679906b
07ec8ff
cb9c4d6
03f02a9
ffc062d
afec303
aeb14e0
a4a9a2e
2a26e67
9e70889
88d100e
e0ff623
4eb0ee4
b0b5756
1235846
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add some dart doc on each attribute? Some of them I can infer their meaning from the name, but not all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
rst*
attributes are used in therstTransforms
argument for thecanvas.drawRawAtlas
function.We do need to have proper documentation for them, but I was thinking of leaving that for later, since we still need to merge
GlyphData
andGlyphInfo
classes, plus there would be some reorganization of this class to support non-monospace fonts.