feat: add HasAncestor mixin
#1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renancaraujo
reviewed
Jun 7, 2022
| } | ||
| assert( | ||
| _ancestor != null, | ||
| 'An ancestor must be of type $T in the component tree', |
There was a problem hiding this comment.
Suggested change
| 'An ancestor must be of type $T in the component tree', | |
| 'Component of type $runtimeType has to have an ancestor of type $T in the component tree', |
There was a problem hiding this comment.
The assertion will already throw with a stack trace that relates to the component. Not sure if this would have any benefit directly then?
If we do this we should do that for the ParentIsA and HasGameRef.
There was a problem hiding this comment.
Just a suggestion on a better error message. Rather than searching the trace for the root of the problem, having the runtime type on the message can be helpful. If the case is for consistency, we can improve this and all related messages in a future PR
There was a problem hiding this comment.
Yea would love to do that in a follow up PR then! As we might have more assertions that could use some love probably
spydon
reviewed
Jun 7, 2022
spydon
approved these changes
Jun 7, 2022
…/flame into feat/add-has-ancestor-mixin
wolfenrain
requested review from
spydon,
erickzanardo,
luanpotter and
renancaraujo
spydon
approved these changes
Jun 8, 2022
erickzanardo
approved these changes
Jun 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a mixin that ensures a component requires a certain ancestor in it's component tree.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Related Issues