feat: Helpers for whether a PositionComponent is flipped.
#1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
requested review from
wolfenrain,
erickzanardo,
luanpotter,
renancaraujo and
st-pasha
luanpotter
reviewed
Jun 5, 2022
| component.flipHorizontallyAroundCenter(); | ||
| expect(component.isFlippedHorizontally, isTrue); | ||
| component.flipHorizontallyAroundCenter(); | ||
| expect(component.isFlippedHorizontally, isFalse); |
There was a problem hiding this comment.
I wonder what happens if "flip" with one version and "unflip" with the other
There was a problem hiding this comment.
I think that it will move the component from its original position (which I think makes sense), if I remember correctly this is documented somewhere, maybe on the dartdocs.
st-pasha
approved these changes
Jun 5, 2022
| /// Whether it is currently flipped horizontally. | ||
| bool get isFlippedHorizontally => transform.scale.x.isNegative; | ||
|
|
||
| /// Whether it is currently flipped horizontally. |
|
Related issue #1336 |
spydon
commented
Jun 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Helpers that just check if the scale is negative so that the user can now whether the component has been flipped.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Related Issues
Closes #1336