Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix remaining broken and redirected links #1664

Merged
merged 3 commits into from
May 27, 2022

Conversation

st-pasha
Copy link
Contributor

@st-pasha st-pasha commented May 27, 2022

Description

Some links still remain broken after #1663, as reported by linkcheck. This PR fixes all of them, except these 5:

Some of these links are actually working, but the script cannot verify that without executing javascript. Not sure what to do about these -- perhaps either the example page needs to be updated so that it lists which links it has; or we directly include these examples into the docs page?

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • [-] I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples.

Breaking Change

  • [-] Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

#1509

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, was suspecting that there were more broken JS ones but didn't have time to check them all. 😅

I can fix the remaining 5 later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants