Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Subscription for events when game changes in GameWidget #1659

Merged
merged 2 commits into from
May 27, 2022
Merged

fix: Subscription for events when game changes in GameWidget #1659

merged 2 commits into from
May 27, 2022

Conversation

st-pasha
Copy link
Contributor

Description

Make sure that subscription to GameStateChange events is properly updated when the game: property of a GameWidget changes.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • [-] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples.

Breaking Change

  • [-] Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Closes #1658

spydon
spydon approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it so quickly!

@spydon spydon added the blocking release This needs to be fixed to be able to release the next version label May 27, 2022
@spydon spydon merged commit 04f0d5d into flame-engine:main May 27, 2022
@st-pasha st-pasha deleted the ps/overlays-removal branch May 28, 2022 00:05
st-pasha added a commit to st-pasha/flame that referenced this pull request May 29, 2022
@st-pasha
fix: Subscription for events when game changes in GameWidget (flame-e…
b52d115 
…ngine#1659)

Make sure that subscription to GameStateChange events is properly updated when the game: property of a GameWidget changes.
st-pasha added a commit to st-pasha/flame that referenced this pull request Jun 3, 2022
@st-pasha
fix: Subscription for events when game changes in GameWidget (flame-e…
7479423 
…ngine#1659)

Make sure that subscription to GameStateChange events is properly updated when the game: property of a GameWidget changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfenrain wolfenrain wolfenrain approved these changes

@spydon spydon spydon approved these changes

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

@luanpotter luanpotter Awaiting requested review from luanpotter

Assignees
No one assigned
Labels
blocking release This needs to be fixed to be able to release the next version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overlays sometimes can't be removed
3 participants
@st-pasha @spydon @wolfenrain