Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ability to add/remove multiple overlays at once #1657

Merged
merged 7 commits into from
May 27, 2022
Merged

feat: Add ability to add/remove multiple overlays at once #1657

merged 7 commits into from
May 27, 2022

Conversation

Hwan-seok
Copy link
Contributor

Description

As described #1546, It would be more convenient and can reduce the game widget updates if adding or removing overlays at once.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Closes #1546

spydon
spydon approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Too bad that Set.addAll doesn't return a bool like Set.add, then you wouldn't have had to check the set length.

@Hwan-seok
Copy link
Contributor Author

Lgtm! Too bad that Set.addAll doesn't return a bool like Set.add, then you wouldn't have had to check the set length.

I agree... what a tragedy it is

@st-pasha
Copy link
Contributor

In the title: availability -> ability

@Hwan-seok Hwan-seok changed the title feat: Add availability to add/remove multiple overlays at once feat: Add ability to add/remove multiple overlays at once May 27, 2022
@spydon spydon merged commit 0ac84c0 into flame-engine:main May 27, 2022
@Hwan-seok Hwan-seok deleted the hwanseok.enhance-overlay branch May 27, 2022 23:36
st-pasha pushed a commit to st-pasha/flame that referenced this pull request May 29, 2022
@Hwan-seok @st-pasha
feat: Add ability to add/remove multiple overlays at once (flame-engi…
005ca7b 
…ne#1657)

As described flame-engine#1546, It would be more convenient and can reduce the game widget updates if adding or removing overlays at once.
st-pasha pushed a commit to st-pasha/flame that referenced this pull request Jun 3, 2022
@Hwan-seok @st-pasha
feat: Add ability to add/remove multiple overlays at once (flame-engi…
31281dd 
…ne#1657)

As described flame-engine#1546, It would be more convenient and can reduce the game widget updates if adding or removing overlays at once.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfenrain wolfenrain wolfenrain approved these changes

@spydon spydon spydon approved these changes

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

@luanpotter luanpotter Awaiting requested review from luanpotter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Availability to add/remove multiple overlays at once
4 participants
@Hwan-seok @st-pasha @spydon @wolfenrain