Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add onReleased callback for HudButtonComponent #1296

Merged
merged 6 commits into from
Jan 7, 2022
Merged

feat: Add onReleased callback for HudButtonComponent #1296

merged 6 commits into from
Jan 7, 2022

Conversation

ufrshubham
Copy link
Member

@ufrshubham ufrshubham commented Jan 5, 2022

Description

This PR adds an onReleased callback to HudButtonComponent which will be called when button is released.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the
relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • (NA) I have updated/added tests for ALL new/updated/fixed functionality.
  • (NA) I have updated/added relevant examples in examples.

Breaking Change

Does your PR require Flame users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change. (Indicate it in the Conventional Commit prefix with a !,
    e.g. feat!:, fix!:).
  • No, this is not a breaking change.

Related Issues

Fixes #1290

@spydon
Copy link
Member

spydon commented Jan 7, 2022

The docs need a small update with this argument too.

@ufrshubham
Copy link
Member Author

@spydon I've updated the docs. Should this also be added in changelog?

@spydon
Copy link
Member

spydon commented Jan 7, 2022

@spydon I've updated the docs. Should this also be added in changelog?

The changelog is automatically generated by Melos now, so you don't have to fill it in yourself.

@spydon spydon enabled auto-merge (squash) January 7, 2022 13:28
@spydon spydon merged commit 87ee34c into flame-engine:main Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An onReleased callback for HudButtonComponent
2 participants