Feature/cleanup u3v class #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iitaku
reviewed
Sep 3, 2024
src/bb/image-io/rt_u3v.h
Outdated
| @@ -484,6 +484,22 @@ class U3V { | |||
| return err_; | |||
| } | |||
|
|
|||
| void ValidateUserInput(int32_t num_detected_device, char* dev_id){ | |||
There was a problem hiding this comment.
Let's unify the naming convention. In ion-kit, we use snake_case for the function and variable name.
There was a problem hiding this comment.
resolved in 0a63a5b
src/bb/image-io/rt_u3v.h
Outdated
| log::info("Acquisition option::{} is {}", "frame_sync_", frame_sync_); | ||
| log::info("Acquisition option::{} is {}", "realtime_display_mode_", realtime_display_mode_); | ||
| } | ||
|
|
||
| GError* CommandAcquisitionModeContdStart(){ |
There was a problem hiding this comment.
Do we have a specific policy for the error handling? It looks function is expected to return GError *, but it actually throws an exception in many cases.
There was a problem hiding this comment.
Updated in c654c02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compress the constructor of U3V and U3VGenDC