[Config] Conditionally mark closures as Sendable for Xcode 16 #14314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
changed the title
paulb777
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I downloaded last Xcode 15 version, Xcode 15.4, to test and found that adding Sendable to the closure params created a warning when the call site inherited an isolation domain (main actor, global actor, etc.). The warning is more disruptive to Xcode 15 users since Xcode 15 does not include Swift 6 language version.
In Xcode 16, the same warning appears for Swift 5 users and is an error in Swift 6.
Conclusion– no new warnings for Xcode 15. New warnings for Xcode 16 where newly Sendable completion handler will warn about changing properties belonging to other isolation domains (see screenshot). New warnings are errors in Swift 6 mode in Xcode 16.
Fixes #14257