[Auth] Mark *Credential classes as Sendable #14100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These classes have no mutable state so they should meet the semantic requirements of Sendable. In Firebase 12, we should refactor to checked Sendable. We can't currently do so without a breaking change because of the fact that the classes are
open
(Sendable classes may not beopen
).Resolves:
Because the APIs return the
AuthCredential
superclass,AuthCredential
needs to be marked unchecked Sendable. All of it's subclasses need to then be marked unchecked Sendable or a warning will occur that the sendability of the superclass means the subclass should also explicitly mark itself as unchecked Sendable.I added some API improvement ideas to the Firebase 12 gdoc.
#no-changelog