Rename crate to finalfusion-python #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebpuetz
approved these changes
Jul 23, 2019
|
Changes look fine but CI fails because of |
|
Seems to be the commit that messed up things for us. |
|
The problem is that pyo3-pack from crates.io does not contain Cargo.lock and will thus pin dependencies to the latest version that the constraints in |
This avoids that there are two crates named finalfusion.
|
Should be fixed now, we'll hear from CI soon ;). The problem seems to be that cargo does not include Learned something new today. |
|
See the release notes of Cargo 1.37, which will include functionality to add/use lock files for binary crates: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids that there are two crates named finalfusion.
No problems building this locally, let's see if CI is happy as well.