Clean command: removes installation from state if directory missing. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoverbear
reviewed
Jan 8, 2025
|
|
||
| let state_file_in_root = root.join("state.json"); | ||
| let mut state_file = std::fs::File::create(&state_file_in_root).unwrap(); | ||
| let content = json!({ |
There was a problem hiding this comment.
I don't love that this is effectively StateRepr but untyped. :(
But I understand why.
Hoverbear
reviewed
Jan 8, 2025
crates/criticalup-cli/tests/snapshots/cli__clean__clean_deletes_only_unused_installations.snap
Outdated
Show resolved
Hide resolved
Hoverbear
reviewed
Jan 8, 2025
crates/criticalup-cli/tests/snapshots/cli__clean__clean_deletes_only_unused_installations.snap
Outdated
Show resolved
Hide resolved
Hoverbear
reviewed
Jan 8, 2025
...ests/snapshots/cli__clean__clean_deletes_only_unused_installations_that_are_not_on_disk.snap
Show resolved
Hide resolved
|
Can we remove the duplication? We don't need two lines per uninstall: |
This was a bug that if the directory of the installation is missing from the file system, and the installation is still present in the state file, the clean command will not remove the installation from the state file. This was certainly a problem because if there is accidental deletion of the toolchain directory, we need to be able to clean up the state file too.
amanjeev
force-pushed
the
amanjeev/clean-command-uiux
branch
from
d67915a to
31a0e21
Compare
Converted one tracing::info to tracing::debug. Reviewed-by: Ana Hobden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bug that if the directory of the installation is missing from the file system, and the installation is still present in the state file, the clean command will not remove the installation from the state file. This was certainly a problem because if there is accidental deletion of the toolchain directory, we need to be able to clean up the state file too.
Start with a clean state.json.
For best results, delete the entire criticalup installation directory.
Install project 1
Use this manifest to install first project. Name this file project1.toml.
Install this project
Check state.json
state.json file should contain an installation with ID "c8f887068792bbf1f09ce4b6ddbe84fd7d9dcde18407d608968c26b89862d15e".
Delete the installation directory
In the appropriate location of toolchain installations, find the directory where this is installed and delete the toolchain of this project only.
DO NOT delete the root directory of CriticalUp configs and installation.
On Linux, you can see this at
~/.local/share/criticalup/toolchains/c8f887068792bbf1f09ce4b6ddbe84fd7d9dcde18407d608968c26b89862d15e/.Run clean
Result: you should see that the state.json file does not have the installation of the above.