Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python sdk bug fixes #723

Merged
merged 1 commit into from
May 21, 2020
Merged

Python sdk bug fixes #723

merged 1 commit into from
May 21, 2020

Conversation

zhilingc
Copy link
Collaborator

What this PR does / why we need it:

Fixes:

  1. feast feature-sets list properly lists all feature sets
  2. client.apply() doesn't demand for project to be set. Setting of default is deferred to the server.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@khorshuheng
Copy link
Collaborator

/lgtm

@zhilingc
Copy link
Collaborator Author

/test test-end-to-end

@zhilingc
Copy link
Collaborator Author

/test test-end-to-end-batch

@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented May 21, 2020

@zhilingc: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-end-to-end b081f82 link /test test-end-to-end

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@khorshuheng khorshuheng merged commit 2d8d7ac into feast-dev:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants