Teardown infrastructure after integration tests

[achals]

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:

The test_offline_online_store_consistency.py integration test didn't tear down any infrastructure after running. This led to an issue where we ran past the number of dynamo tables allowed for an account: https://github.com/feast-dev/feast/runs/3014392319?check_suite_focus=true

This PR changes the integration test to tear down the infrastructure set up by the fixtures.

Which issue(s) this PR fixes:

Fixes #1696.

Does this PR introduce a user-facing change?:

NONE

[codecov-commenter]

Codecov Report

Merging #1697 (f88e12e) into master (0d2179d) will increase coverage by 0.50%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master    #1697      +/-   ##
==========================================
+ Coverage   82.75%   83.25%   +0.50%     
==========================================
  Files          76       76              
  Lines        6754     6778      +24     
==========================================
+ Hits         5589     5643      +54     
+ Misses       1165     1135      -30     

Flag	Coverage Δ
integrationtests	83.18% <95.83%> (+0.50%)	⬆️
unittests	69.91% <66.66%> (+0.18%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/feature_store.py	94.35% <92.85%> (-0.09%)	⬇️
...hon/tests/test_offline_online_store_consistency.py	100.00% <100.00%> (ø)
sdk/python/feast/infra/offline_stores/bigquery.py	76.14% <0.00%> (ø)
sdk/python/feast/infra/online_stores/redis.py	92.85% <0.00%> (+0.89%)	⬆️
sdk/python/feast/infra/online_stores/sqlite.py	97.59% <0.00%> (+1.20%)	⬆️
sdk/python/feast/registry.py	81.29% <0.00%> (+1.36%)	⬆️
sdk/python/feast/infra/local.py	92.15% <0.00%> (+1.96%)	⬆️
sdk/python/feast/infra/gcp.py	100.00% <0.00%> (+2.17%)	⬆️
sdk/python/feast/infra/aws.py	100.00% <0.00%> (+2.27%)	⬆️
sdk/python/feast/infra/online_stores/dynamodb.py	91.13% <0.00%> (+8.86%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2179d...f88e12e. Read the comment docs.

[tsotnet]

@achals Should we add the teardown method to the FeatureStore class instead of calling a private method on it?

[achals]

@achals Should we add the teardown method to the FeatureStore class instead of calling a private method on it?

Definitely, that's what I wanted with #1696. I made this PR because I thought it may need to be landed sooner than that - if we're okay with me taking a few more hours I can fix that issue and update this PR to use the teardown method directly. What do you think?

[woop]

@achals Should we add the teardown method to the FeatureStore class instead of calling a private method on it?

Definitely, that's what I wanted with #1696. I made this PR because I thought it may need to be landed sooner than that - if we're okay with me taking a few more hours I can fix that issue and update this PR to use the teardown method directly. What do you think?

sgtm

[felixwang9817]

had one small nit, otherwise lgtm

[felixwang9817]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [achals]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment