Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo and project names should not start with an underscore #1597

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

tedhtchang
Copy link
Contributor

@tedhtchang tedhtchang commented May 28, 2021

Signed-off-by: ted chang [email protected]

Address comments in PR #1558

feast apply or init commands will exit if project or repo name start with an underscore.

/cc @woop @dmatrix

@tedhtchang tedhtchang requested review from jklegar, tsotnet, woop and a team as code owners May 28, 2021 23:28
@feast-ci-bot feast-ci-bot removed the request for review from a team May 28, 2021 23:28
@feast-ci-bot
Copy link
Collaborator

@tedhtchang: GitHub didn't allow me to request PR reviews from the following users: dmatrix.

Note that only feast-dev members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Signed-off-by: ted chang [email protected]

What this PR does / why we need it:
Address comments in PR #1558

-->

feast apply or init commands will exit if project or repo name start with an underscore.

/cc @woop @dmatrix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feast-ci-bot
Copy link
Collaborator

Hi @tedhtchang. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2021

Codecov Report

Merging #1597 (4e31485) into master (17231d0) will increase coverage by 0.05%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1597      +/-   ##
==========================================
+ Coverage   83.88%   83.94%   +0.05%     
==========================================
  Files          67       67              
  Lines        5883     5903      +20     
==========================================
+ Hits         4935     4955      +20     
  Misses        948      948              
Flag Coverage Δ
integrationtests 83.85% <87.50%> (+0.05%) ⬆️
unittests 77.72% <87.50%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/repo_operations.py 32.17% <25.00%> (ø)
sdk/python/tests/test_init.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17231d0...4e31485. Read the comment docs.

@woop
Copy link
Member

woop commented May 28, 2021

/kind housekeeping

@woop
Copy link
Member

woop commented May 28, 2021

/ok-to-test

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would it be feasible to add tests to cover this case?

sdk/python/feast/repo_operations.py Outdated Show resolved Hide resolved
@tedhtchang tedhtchang force-pushed the enhance-name-validation branch 2 times, most recently from e1cf1a3 to 9a82640 Compare June 7, 2021 11:03
@woop
Copy link
Member

woop commented Jun 7, 2021

@tedhtchang you may have to rebase to get tests to pass

@tedhtchang tedhtchang force-pushed the enhance-name-validation branch from 9a82640 to 9e74887 Compare June 8, 2021 00:45
Signed-off-by: ted chang <[email protected]>
@feast-ci-bot feast-ci-bot added size/M and removed size/S labels Jun 8, 2021
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, tedhtchang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals
Copy link
Member

achals commented Jun 8, 2021

Thank you for the PR @tedhtchang!!

@feast-ci-bot feast-ci-bot merged commit 4fdebcd into feast-dev:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants