-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo and project names should not start with an underscore #1597
Repo and project names should not start with an underscore #1597
Conversation
@tedhtchang: GitHub didn't allow me to request PR reviews from the following users: dmatrix. Note that only feast-dev members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @tedhtchang. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1597 +/- ##
==========================================
+ Coverage 83.88% 83.94% +0.05%
==========================================
Files 67 67
Lines 5883 5903 +20
==========================================
+ Hits 4935 4955 +20
Misses 948 948
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/kind housekeeping |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, would it be feasible to add tests to cover this case?
e1cf1a3
to
9a82640
Compare
@tedhtchang you may have to rebase to get tests to pass |
Signed-off-by: ted chang <[email protected]>
9a82640
to
9e74887
Compare
Signed-off-by: ted chang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, tedhtchang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you for the PR @tedhtchang!! |
Signed-off-by: ted chang [email protected]
Address comments in PR #1558
/cc @woop @dmatrix