-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add materialize_incremental method #1407
Merged
feast-ci-bot
merged 3 commits into
feast-dev:master
from
jklegar:jacob_materialize_incremental
Mar 25, 2021
Merged
Add materialize_incremental method #1407
feast-ci-bot
merged 3 commits into
feast-dev:master
from
jklegar:jacob_materialize_incremental
Mar 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note this is stacked on #1403 |
woop
reviewed
Mar 23, 2021
sdk/python/tests/test_materialize_from_bigquery_to_datastore.py
Outdated
Show resolved
Hide resolved
jklegar
force-pushed
the
jacob_materialize_incremental
branch
from
March 24, 2021 17:26
8217cf9
to
63bf9e3
Compare
woop
reviewed
Mar 24, 2021
Just waiting for rebase. |
Signed-off-by: Jacob Klegar <[email protected]>
Signed-off-by: Jacob Klegar <[email protected]>
Signed-off-by: Jacob Klegar <[email protected]>
jklegar
force-pushed
the
jacob_materialize_incremental
branch
from
March 25, 2021 15:33
63bf9e3
to
93c1677
Compare
/lgtm |
woop
approved these changes
Mar 25, 2021
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jklegar, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Add materialize_incremental method to materialize into online store from most recent end date
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: