Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature to append to body the form parameters #60

Merged
merged 7 commits into from
Apr 5, 2019

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Mar 14, 2019

This feature implements #59 adding an option to write in the req.body the parameters and let add a validation to the parameters.

README.md Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
test/multipart.test.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@Eomm
Copy link
Member Author

Eomm commented Mar 29, 2019

Fixed the comments 👍🏼

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not really fond of “manageUploadStream”, maybe something like “onFile” is simpler?

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work!

README.md Outdated Show resolved Hide resolved
@Eomm
Copy link
Member Author

Eomm commented Apr 4, 2019

May I release it as minor? (now the version is 0.7.0)

LGTM, good work!

Thank you for the patience 👍

@mcollina
Copy link
Member

mcollina commented Apr 4, 2019 via email

@Eomm
Copy link
Member Author

Eomm commented Apr 4, 2019

I can't do it 😅

Looking the repositories list of my team, it seems that this repo is not in

There are 36 repo, some other is missing

@mcollina
Copy link
Member

mcollina commented Apr 5, 2019

now you can ;)

@Eomm Eomm merged commit c40bce0 into fastify:master Apr 5, 2019
@Eomm Eomm deleted the feature/add-to-body branch April 5, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants