-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add feature to append to body the form parameters #60
Conversation
Fixed the comments 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not really fond of “manageUploadStream”, maybe something like “onFile” is simpler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work!
May I release it as minor? (now the version is
Thank you for the patience 👍 |
minor it is
Il giorno gio 4 apr 2019 alle 20:00 Manuel Spigolon <
[email protected]> ha scritto:
… May I release it as minor? (now the version is 0.7.0)
LGTM, good work!
Thank you for the patience 👍
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#60 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADL46WGfsqz3C7k1jNVzQ7OPEDEp4D9ks5vdj3TgaJpZM4b0OvK>
.
|
I can't do it 😅 Looking the repositories list of my team, it seems that this repo is not in There are 36 repo, some other is missing |
now you can ;) |
This feature implements #59 adding an option to write in the
req.body
the parameters and let add a validation to the parameters.