-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add typings to org repo #56
Conversation
I forgot to update the unit test script here, but somehow the tests are failing for me, locally anyway. I tried resetting to a specific commit and one test also fails there. I'm on MacOS and tried different node versions to no success. I tried on commit: 3bb2b07 |
.travis.yml
Outdated
- windows | ||
|
||
script: | ||
- npm run lint && npm run coveralls && npm run typescript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm run coveralls
does not exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed it does not. Oversight on my part, carryover from another plugin repo.
One test is a bit flaky, don't worry about it. |
I cannot commit my changes because that one test keeps failing.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation: see here
This PR adds a modified version of my typings on DefinitelyTyped to the org repo as that seems to be the consensus now.