Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typings to org repo #56

Merged
merged 2 commits into from
Feb 10, 2019
Merged

Conversation

jannikkeye
Copy link
Contributor

@jannikkeye jannikkeye commented Feb 4, 2019

Motivation: see here

This PR adds a modified version of my typings on DefinitelyTyped to the org repo as that seems to be the consensus now.

@jannikkeye
Copy link
Contributor Author

I forgot to update the unit test script here, but somehow the tests are failing for me, locally anyway. I tried resetting to a specific commit and one test also fails there. I'm on MacOS and tried different node versions to no success. I tried on commit: 3bb2b07

.travis.yml Outdated
- windows

script:
- npm run lint && npm run coveralls && npm run typescript
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run coveralls does not exists.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it does not. Oversight on my part, carryover from another plugin repo.

@mcollina
Copy link
Member

mcollina commented Feb 8, 2019

One test is a bit flaky, don't worry about it.

@jannikkeye
Copy link
Contributor Author

I cannot commit my changes because that one test keeps failing.

npm run unit

> [email protected] unit /Users/janisis/code/fastify-multipart
> tap test/*.test.js

test/multipart.test.js .............................. 42/43
  should call finished when both files are pumped
  not ok should be equal
    +++ found                                                           
    --- wanted                                                          
    -2                                                                  
    +0                                                                  
    compare: ===
    at:
      line: 97
      column: 9
      file: test/multipart.test.js
      type: Immediate
      method: _onImmediate
    stack: |
      Immediate._onImmediate (test/multipart.test.js:97:9)
    source: |
      t.equal(fileCount, 2)

total ............................................... 42/43
  

  42 passing (10s)
  1 failing

@mcollina
Copy link
Member

mcollina commented Feb 8, 2019

git commit -n

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 43de985 into fastify:master Feb 10, 2019
@jannikkeye jannikkeye deleted the typings branch February 11, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants