Expose busboy options, update docs and tests. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Apr 3, 2018
index.js
Outdated
| @@ -40,7 +40,7 @@ function fastifyMultipart (fastify, options, done) { | |||
|
|
|||
| const req = this.req | |||
|
|
|||
| const stream = new Busboy({ headers: req.headers }) | |||
| const stream = new Busboy(Object.assign({ headers: req.headers }, options)) | |||
There was a problem hiding this comment.
@nigelhanlon I would prefer if we copied the options using an Object.keys() and for loop instead. Object.assign() is super slow and it will likely still be slow in Node 10 (see https://twitter.com/dan_abramov/status/980436488860196864).
mcollina
reviewed
Apr 3, 2018
index.js
Outdated
| const busboyOptions = { headers: req.headers } | ||
| for (let opt of Object.keys(options)) { | ||
| busboyOptions[opt] = options[opt] | ||
| } |
There was a problem hiding this comment.
for of is super slow as well (also using let in loops is slow), you'd need a nice old for (var i = 0; i< n; i++).
There was a problem hiding this comment.
Do you mean something like this?
const busboyOptions = { headers: req.headers }
const keys = Object.keys(options)
for (var i = 0; i < keys.length; i++) {
busboyOptions[keys[i]] = options[keys[i]]
}
const stream = new Busboy(busboyOptions)
|
Can you remove the spurious package-lock file and add it to .gitignore? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows end users to pass options to the internal busboy module when registering the plugin with fastify. This is useful as you currently cannot set upload limits which are supported by busboy internally.
The supported options are documented on the busboy page here. I have included an updated readme and updated tests to reflect the proposed changes. Feed back and suggestions welcome.