Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3): Support S3 Region #12063

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

majetideepak
Copy link
Collaborator

@majetideepak majetideepak commented Jan 11, 2025

We will follow a subset of the Hadoop aws library rules to be consistent with other applications. These rules seem reasonable.
https://hadoop.apache.org/docs/current/hadoop-aws/tools/hadoop-aws/connecting.html#s3_endpoint_region_details

  1. Configs hive.s3.endpoint and hive.s3.endpoint.region are used to set values for S3 endpoint and region respectively.
  2. If hive.s3.endpoint.region is configured with valid AWS region value, S3FS will use this value.
  3. If hive.s3.endpoint.region is not set and hive.s3.endpoint is set with valid endpoint value, S3FS will attempt to parse the region from the endpoint and configure the client to use the region value.
  4. If both hive.s3.endpoint and hive.s3.endpoint.region are not set, S3FS will use us-east-2 as default region and enable cross-region access. In this case, S3FS does not attempt to override the endpoint while configuring the S3 client.

Fixes: #11627

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 11, 2025
@majetideepak majetideepak requested a review from JkSelf January 11, 2025 01:46
Copy link

netlify bot commented Jan 11, 2025

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit d427dc1
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6781cd52ce323d00083bd5a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for S3 Region
2 participants