feat: Support dynamic filters for Right Join #12057
Open
+86
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
mbasmanova
reviewed
Jan 10, 2025
There was a problem hiding this comment.
@xiaodouchen Thank you for adding this optimization. Looks good to me.
Would you update the documentation at https://facebookincubator.github.io/velox/develop/joins.html#dynamic-filter-pushdown ? It currently says "Dynamic filter pushdown optimization is enabled for inner, left semi, and right semi joins."
Would you also check if we get Fuzzer coverage for this new code flow. CC: @kagamiori
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support dynamic filters for right join. Note: Right join can not be
completely replaced with a pushed down filter when build side has no
dependent columns.