build(cmake): Fix remote function benchmark #12038
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
zhouyuan
changed the title
|
@zhouyuan CI is failing. Looks like a typo in the library name? |
This patch addes the missing utf8 lib for remote function benchmark Signed-off-by: Yuan Zhou <[email protected]>
zhouyuan
force-pushed
the
wip_fix_remote_function_benchmark
branch
from
88afdce to
6175998
Compare
|
@majetideepak Thank you for the check. I just fixed the spell and the CI is passing now. thanks, -yuan |
assignUser
approved these changes
Jan 9, 2025
assignUser
changed the title
|
I corrected the title because |
assignUser
added
the
ready-to-merge
majetideepak
approved these changes
Jan 9, 2025
|
@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch added the missing utf8 lib dependency for remote function benchmark
Signed-off-by: Yuan Zhou [email protected]
Fixes: #12039